Prune idle per-host connection semaphores#2277
Merged
hyperxpro merged 1 commit intoJul 23, 2026
Merged
Conversation
Per-host connection limits retained one semaphore and partition key for every host observed by the client, even after all permits were returned. Track holders and waiting acquisitions for each map entry. Remove an entry only after the final reference leaves, so a concurrent acquisition cannot detach from the semaphore used by later callers. Codex on behalf of Pavel Ptashyts Co-Authored-By: Codex <[email protected]>
hyperxpro
approved these changes
Jul 23, 2026
hyperxpro
added a commit
that referenced
this pull request
Jul 24, 2026
Motivation: #2277 prevented the per-host connection map from growing indefinitely by reference counting entries and pruning them when they become idle. This relies on every release matching a prior reservation. An unmatched or double release can prematurely remove a live entry, allowing a new semaphore to be created and silently bypassing the per-host connection limit. The previous lookup method was also left unused in production and, if called, could create entries that were never eligible for pruning. Existing tests covered only a single host. Modification: Log unmatched releases so double releases are visible instead of silently corrupting the reference count. Remove the unused lookup method and update its remaining test. Add concurrent multi-host stress tests for both semaphore implementations, verifying that the per-host limit is enforced under contention and that all entries are pruned once released. Result: Unbalanced releases are now detectable, the unused code path has been removed, and the per-host connection limit is verified under concurrent multi-host workloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PerHostConnectionSemaphoreretained one semaphore and partition key for every host observed by a client. Long-lived clients connecting to many distinct hosts could therefore retain these entries indefinitely.Testing
./mvnw -pl client -Dtest='org.asynchttpclient.netty.channel.SemaphoreTest#perHostRemovesEntriesAfterLastRelease+combinedRemovesEntriesAfterLastRelease+perHostRetainsEntryDuringWaitingAcquire' test./mvnw -pl client -Dtest='org.asynchttpclient.netty.channel.SemaphoreTest,org.asynchttpclient.netty.channel.ChannelManagerHttp2DrainPermitTest,org.asynchttpclient.netty.NettyRequestThrottleTimeoutTest' test(346 tests)./mvnw -B -ntp -pl client -DskipTests -Dmaven.javadoc.skip=true -Dgpg.skip=true verify(includes Revapi)The required JDK 11
./mvnw clean verifywas not run because JDK 11 is not available in the local environment. CI will exercise the complete supported JDK matrix.Codex on behalf of Pavel Ptashyts